Fix bug in mbedtls_x509_set_extension#8688
Merged
paul-elliott-arm merged 7 commits intoJan 10, 2024
Merged
Conversation
Signed-off-by: Jonathan Winzig <jwinzig@hilscher.com>
Signed-off-by: Jonathan Winzig <jwinzig@hilscher.com>
davidhorstmann-arm
requested changes
Jan 9, 2024
Co-authored-by: David Horstmann <david.horstmann@arm.com> Signed-off-by: Jonathan Winzig <jwinzig@hilscher.com>
Signed-off-by: Jonathan Winzig <jwinzig@hilscher.com>
davidhorstmann-arm
requested changes
Jan 9, 2024
davidhorstmann-arm
left a comment
Contributor
There was a problem hiding this comment.
A couple of small nits, looks good otherwise
Co-authored-by: David Horstmann <david.horstmann@arm.com> Signed-off-by: Jonathan Winzig <jwinzig@hilscher.com>
Signed-off-by: Jonathan Winzig <jwinzig@hilscher.com>
davidhorstmann-arm
previously approved these changes
Jan 9, 2024
davidhorstmann-arm
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks!
paul-elliott-arm
suggested changes
Jan 9, 2024
paul-elliott-arm
left a comment
Member
There was a problem hiding this comment.
Unfortunately the tests are failing because mbedtls_x509write_csr_init() is not defined under all configs - I have suggested a fix for this. Otherwise LGTM
Co-authored-by: Paul Elliott <62069445+paul-elliott-arm@users.noreply.github.com> Signed-off-by: Jonathan Winzig <jwinzig@hilscher.com>
Contributor
|
@jwinzig-at-hilscher once this is ready, please can you provide a backport to 2.28 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds tests and a fix for Issue #8687.
PR checklist