Skip to content

Add example program for PSA sign verify#7954

Open
tom-daubney-arm wants to merge 11 commits intoMbed-TLS:developmentfrom
tom-daubney-arm:psa_crypto_example_sign_verify
Open

Add example program for PSA sign verify#7954
tom-daubney-arm wants to merge 11 commits intoMbed-TLS:developmentfrom
tom-daubney-arm:psa_crypto_example_sign_verify

Conversation

@tom-daubney-arm
Copy link
Copy Markdown
Contributor

@tom-daubney-arm tom-daubney-arm commented Jul 18, 2023 •
edited
Loading

Description

This PR contains the PSA sign verify program, originally authored by @hannestschofenig .

This PR is the seventh part of a series of PRs that are based on #5064 , which has been split in order to make reviewing easier.

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

  • changelog done
  • backport not required
  • tests not required

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

@tom-daubney-arm tom-daubney-arm added enhancement needs-ci Needs to pass CI tests component-psa PSA keystore/dispatch layer (storage, drivers, …) priority-medium Medium priority - this can be reviewed as time permits labels Jul 18, 2023
@tom-daubney-arm tom-daubney-arm mentioned this pull request Jul 18, 2023
Closed
2 tasks
@tom-daubney-arm tom-daubney-arm added needs-work and removed needs-ci Needs to pass CI tests labels Jul 19, 2023
@daverodgman
Copy link
Copy Markdown
Contributor

daverodgman commented Jul 19, 2023

Test comment

daverodgman
daverodgman reviewed Jul 19, 2023
View reviewed changes
ChangeLog.d/add-psa-example-program-sign-verify.txt
@@ -0,0 +1,2 @@
Features
* Added an example program showing the use of sign verify with the PSA API.
Copy link
Copy Markdown
Contributor

@daverodgman daverodgman Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test comment

@daverodgman daverodgman requested review from daverodgman and removed request for daverodgman July 19, 2023 12:00
@tom-daubney-arm tom-daubney-arm added needs-design-approval size-s Estimated task size: small (~2d) labels Jul 25, 2023
Hannes Tschofenig and others added 5 commits April 3, 2024 11:12
@tom-daubney-arm
Add example program for PSA sign verify
8359fb7 
This commit adds the example program for PSA
sign verify as well as the relevant changes to
CMakeLists.txt and the Makefile.

Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
@tom-daubney-arm
Replace psa_key_handle_t in program
8f92197 
Replace psa_key_handle_t with psa_key_id_t.
Add MBEDTLS_PSA_CRYPTO_KEY_ID_ENCODES_OWNER guards because
psa_key_id_t is used.

Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
@tom-daubney-arm
Bring code-style up-to-date
f5f5c10 
This PR was originally created before the code
style was changed. This commit updates the style.

Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
@tom-daubney-arm
Add ChangeLog entry
963237d 
Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
@tom-daubney-arm
Replace printf with mbedtls_printf.
7bdb2f2 
Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
@tom-daubney-arm tom-daubney-arm force-pushed the psa_crypto_example_sign_verify branch 2 times, most recently from 9c78b16 to a7b6276 Compare April 3, 2024 15:51
@tom-daubney-arm
Add demo script for CI testing
0fd08ed 
Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
@tom-daubney-arm tom-daubney-arm force-pushed the psa_crypto_example_sign_verify branch from a7b6276 to 0fd08ed Compare April 3, 2024 16:13
@tom-daubney-arm
Fix code style
0bc7096 
Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
@tom-daubney-arm
Move constant values out of main()
6f39d6f 
This matches the style implemented in psa hash and makes
for a cleaner looking main function.

Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
@tom-daubney-arm
Return EXIT_SUCCESS from main()
1c642d8 
Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
@tom-daubney-arm
Fix license issue
2a9b601 
Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
@tom-daubney-arm
Add newline to end of script
0b10f82 
Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
@tom-daubney-arm
Copy link
Copy Markdown
Contributor Author

tom-daubney-arm commented Apr 8, 2024

Note for reviewers: I think I have implemented all of the general feedback that came from #7942 in to this program, where relevant. As such, I have removed the needs-design-approval label and marked ready for review.

@tom-daubney-arm tom-daubney-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Apr 8, 2024
@davidhorstmann-arm davidhorstmann-arm self-requested a review April 8, 2024 14:06
@tom-daubney-arm tom-daubney-arm mentioned this pull request Jul 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidhorstmann-arm davidhorstmann-arm Awaiting requested review from davidhorstmann-arm

1 more reviewer

@daverodgman daverodgman daverodgman left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

component-psa PSA keystore/dispatch layer (storage, drivers, …) enhancement needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-medium Medium priority - this can be reviewed as time permits size-s Estimated task size: small (~2d)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tom-daubney-arm @daverodgman