Skip to content

Python 3.14 support #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MatthieuDartiailh merged 27 commits into from
Aug 21, 2025
Merged

Python 3.14 support #166

MatthieuDartiailh merged 27 commits into from
Aug 21, 2025

Conversation

@MatthieuDartiailh
Copy link
Owner

@MatthieuDartiailh MatthieuDartiailh commented Jun 23, 2025 •
edited
Loading

Some backward incompatible changes are also introduce regarding:

  • BINARY_OP that now requires a BinaryOp object as argument (for Instr)
  • FORMAT_VALUE that now requires a FormatValue object as argument
    This align the behavior of those instructions with others using an enum and hence requiring one.

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 81.81818% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.43%. Comparing base (89f2451) to head (dc7da4d).

Files with missing lines Patch % Lines
src/bytecode/concrete.py 50.00% 5 Missing and 3 partials ⚠️
src/bytecode/instr.py 89.83% 5 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
- Coverage   96.14%   95.43%   -0.71%     
==========================================
  Files           7        7              
  Lines        2074     2146      +72     
  Branches      474      481       +7     
==========================================
+ Hits         1994     2048      +54     
- Misses         42       56      +14     
- Partials       38       42       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MatthieuDartiailh
Copy link
Owner Author

MatthieuDartiailh commented Jun 29, 2025 •
edited
Loading

3.14 tests are passing locally with 3.14.0b3 without coverage measurement

@MatthieuDartiailh MatthieuDartiailh mentioned this pull request Jun 30, 2025
Closed
@makslevental
Copy link
Contributor

makslevental commented Jul 24, 2025 •
edited
Loading

Hey just curious is this ready to land? Anything I can do to help it along?

@MatthieuDartiailh
Copy link
Owner Author

MatthieuDartiailh commented Jul 24, 2025

Some test regarding FORMAT_VALUE and BUILD_INTERPOLATION are missing. The changelog need to be updated too and I did not review the docs. If you want to help with the tests you are welcome.

@makslevental
Copy link
Contributor

makslevental commented Jul 24, 2025

Will do - will send soon :)

@MatthieuDartiailh
Copy link
Owner Author

MatthieuDartiailh commented Jul 25, 2025

Actually tests are also missing for validation of the argument of the following instructions: BINARY_OP, FORMAT_VALUE, SPECIAL_METHOD, COMMON_CONSTANT, LOAD_SMALL_INT
For this you can extend: test_instr.py::InstrTest.test_invalid_arg

makslevental
makslevental reviewed Jul 25, 2025
View reviewed changes
tests/test_instr.py
Comment on lines +212 to +264
if opcode.opmap[name] in FORMAT_VALUE_OPS:
Instr(name, (True, FormatValue.ASCII))
else:
Instr(name, (True, "arg"))
Copy link
Contributor

@makslevental makslevental Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI you did/do already have a test for arg validation for FORMAT_VALUE :)

Copy link
Contributor

@makslevental makslevental Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some more tests anyway #167

MatthieuDartiailh and others added 22 commits August 21, 2025 09:11
@MatthieuDartiailh
update for 3.14
ca9650e
@MatthieuDartiailh
enable 3.14 in CIs
9bcecf7
@MatthieuDartiailh
flags: remove reliance on removed opcode
d7a0304
@MatthieuDartiailh
drop support for Python 3.8
9112c91
@MatthieuDartiailh
properly use BinaryOp enum for BINARY_OP opcode
3ec8e3b
@MatthieuDartiailh
cis: fix python version for framework tests
742b317
@MatthieuDartiailh
fix linting issue
b837f21
@MatthieuDartiailh
tests: fix typing error
7b51464
@MatthieuDartiailh
instr: properly handle instruction dealing with formatting and fix Sp…
6b4a2d4 
…ecialMethod enum
@MatthieuDartiailh
tests: fix for 3.14
006fb53
@MatthieuDartiailh
allow slight increase in function complexity and fix version bound on…
40fc121 
… test
@MatthieuDartiailh
fix typing and minor test issues
6de8222
@MatthieuDartiailh
fix typo in test
82fdafe
@MatthieuDartiailh
ci: fix to run framework test on 3.14
795e410
@makslevental @MatthieuDartiailh
tests for validation of the argument of the following instructions: B…
108a4a1 
…INARY_OP, FORMAT_VALUE, SPECIAL_METHOD, COMMON_CONSTANT, LOAD_SMALL_INT
@makslevental @MatthieuDartiailh
use opcode groups
bc8e6c0
@MatthieuDartiailh
pyproject: add depdency groups for development requirements
f6fcfc3
@MatthieuDartiailh
ci: switch to trusted publishing
48d0c95
@MatthieuDartiailh
update XXX comment to FIXME
d6cafe5
@MatthieuDartiailh
ci: upgrade to checkout v5
bcb284d
@MatthieuDartiailh
instr: make usage of BinaryOp enum be backward compatible
6c29624
@MatthieuDartiailh
tests: add test for CONVERT_VALUE/FORMAT_VALUE
6586e60
@MatthieuDartiailh MatthieuDartiailh merged commit 12df292 into main Aug 21, 2025
14 checks passed
@MatthieuDartiailh MatthieuDartiailh deleted the 3.14-support branch August 21, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@makslevental makslevental makslevental left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MatthieuDartiailh @codecov-commenter @makslevental