Added set source callback#20
Merged
MatthewCallis merged 2 commits intoMatthewCallis:masterfrom May 21, 2018
sunknudsen:master
Merged
Added set source callback#20MatthewCallis merged 2 commits intoMatthewCallis:masterfrom sunknudsen:master
MatthewCallis merged 2 commits intoMatthewCallis:masterfrom
sunknudsen:master
Conversation
Owner
|
Hey thanks! Can you write a test for this option too, and the |
Contributor
Author
|
Hey @MatthewCallis, I added the test. Not sure what's up with The changes occurred after running Perhaps Rollup is using the same How can I rebuild for Node.js? Thanks! |
Owner
Contributor
Author
|
Awesome, thanks Matthew! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of the
setSourceCallbackoption is to be able to "listen" to changes in the src of the image element attached to Avatar. This is useful to cache sources provided by third parties such as Gravatar at the app level in order to eliminate image flickering that occurred when refreshing views in single page apps.