keep the path for pkg-config path if they are absolute#98
Merged
Conversation
Contributor
|
This doesn't seem to work for me. I'm running cmake 3.23.1 with the following: |
Contributor
Author
|
Maybe a bug in Can you try with this ? set(PKG_LIBDIR "${CMAKE_INSTALL_LIBDIR}")
set(PKG_INCDIR "${CMAKE_INSTALL_INCLUDEDIR}")
cmake_path(IS_ABSOLUTE PKG_LIBDIR abs_libdir)
cmake_path(IS_ABSOLUTE PKG_INCDIR abs_incdir) |
Contributor
|
That makes no difference. And it shouldn't, as the shell already expands |
04dc9ea to
83d30f0
Compare
Contributor
Author
|
I tried this updated script with older cmake and 3.22.1 (Ubuntu 22.04) and they both work (using absolute path when the path given is absolute, by default the values are not absolute). |
83d30f0 to
42fbae3
Compare
alexshpilkin
approved these changes
May 16, 2022
mbunkus
approved these changes
May 22, 2022
Contributor
mbunkus
left a comment
There was a problem hiding this comment.
This variant works well for me now, both with an absolute path & without specifying the paths at all. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #97