Skip to content

Fix win32/darwin builds and jobs #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tegefaulkes merged 2 commits into from
Mar 18, 2024
Merged

Fix win32/darwin builds and jobs #154

tegefaulkes merged 2 commits into from
Mar 18, 2024

Conversation

@tegefaulkes
Copy link
Contributor

@tegefaulkes tegefaulkes commented Mar 14, 2024 •
edited
Loading

Description

This PR addresses two things.

  1. Fixing the mac and windows builds.
  2. Re-enabling the mac and windows ci tests.

Issues Fixed

Tasks

  • 1. Fix packaged windows build.
  • 2. Fix packaged mac build.
  • 3. Re-enable and fix mac and windows CI jobs

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@tegefaulkes tegefaulkes self-assigned this Mar 14, 2024
@tegefaulkes tegefaulkes force-pushed the feature-enable-jobs branch from 678a8e7 to 655f771 Compare March 14, 2024 06:01
@tegefaulkes tegefaulkes merged commit 1a2769a into staging Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tegefaulkes tegefaulkes

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix missing native modules for mac and windows build

2 participants

@tegefaulkes