-
Notifications
You must be signed in to change notification settings - Fork 5
Fix nodesGetAll handler #611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8c0c57f to
5c5a467
Compare
|
FYI, you don't need to code dump in the issue spec. Implementation detail is less relevant than requirements. You want clear specification of what needs to be done, How the code looks like isn't that use. Focus on what needs to be done and what is required of the code. Not how it will look. |
tegefaulkes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to review the tests for this. no tests caught the problem so either they are insufficient or non-existent. Look into it.
You are right, currently no tests exist for getAll. I will make one to test the same. |
|
Likely there is no test for the |
Yep, there are currently only tests for |
5171a30 to
8d96f68
Compare
tegefaulkes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little more polish, Once that is done, so long as all the test pass, you can proceed to merge.
b6476ad to
e6e9929
Compare
746eb97 to
a87e932
Compare
|
Good work! |

Description
nodesGetAllhandler was obsolete and was breaking operation ofnodes getAllon Polykey-CLI.This simple PR just fixes the handler.
Handler previously was:
And now is changed to:
Issues Fixed
Tasks
Final checklist