Really using the given voxel_index in remove_agent_from_voxel#159
Merged
MathCancer merged 1 commit intoMathCancer:developmentfrom Jul 26, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies remove_agent_from_voxel, to actually use the voxel_index used in function's argument. This is needed when an agent span multiple voxels (such as in PhysiMESS).
In current PhysiCell, this argument is ignored, and the current_mechanics_voxel is queried to know which voxel to remove the agent from. However, in current PhysiCell, this function is always called with the current_mechanics_voxel as argument. So this fix won't have any effect on current PhysiCell, and will allow PhysiCell extension where agents can span multiple voxels.