persist: pass batches of records around in a columnar allocation#8551
Closed
danhhz wants to merge 1 commit intoMaterializeInc:mainfrom
Closed
persist: pass batches of records around in a columnar allocation#8551danhhz wants to merge 1 commit intoMaterializeInc:mainfrom
danhhz wants to merge 1 commit intoMaterializeInc:mainfrom
Conversation
ruchirK
approved these changes
Oct 6, 2021
Contributor
ruchirK
left a comment
There was a problem hiding this comment.
Reviewed columnar.rs - this makes a ton of sense and helps me see the idea clearly. I'll play around with this for perf testing / noodle on making it consolidate-able tomorrow. Thanks for whipping it up!
|
|
||
| pub fn finish(mut self) -> ColumnarRecords { | ||
| self.records.key_offsets.push(self.records.key_data.len()); | ||
| self.records.val_offsets.push(self.records.val_data.len()); |
Contributor
There was a problem hiding this comment.
I think this is a good place to debug assert the ColumnarRecord validity postconditions
2 tasks
Contributor
Author
|
Replaced by #9165 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP prototype for discussion