Skip to content

pg-cdc test: Fix certificate generation process for tests#35751

Merged
def- merged 1 commit intoMaterializeInc:mainfrom
def-:pr-fix-cert-test
Mar 27, 2026
Merged

pg-cdc test: Fix certificate generation process for tests#35751
def- merged 1 commit intoMaterializeInc:mainfrom
def-:pr-fix-cert-test

Conversation

@def-
Copy link
Copy Markdown
Contributor

@def- def- commented Mar 27, 2026

Follow-up to #35487

Causing test failures in main, see for example: https://buildkite.com/materialize/test/builds/119386#019d2eee-d56c-4bd2-8d5e-409525b0a147

pg-cdc-ssl-ca-bundle.td:38:1: executing query failed: db error: ERROR: error performing TLS handshake: error:0A000086:SSL routines:tls_post_process_server_certificate:certificate verify failed:ssl/statem/statem_clnt.c:2091:: self-signed certificate in certificate chain: error:0A000086:SSL routines:tls_post_process_server_certificate:certificate verify failed:ssl/statem/statem_clnt.c:2091:: error:0A000086:SSL routines:tls_post_process_server_certificate:certificate verify failed:ssl/statem/statem_clnt.c:2091:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2026

Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone.

PR title guidelines

  • Use imperative mood: "Fix X" not "Fixed X" or "Fixes X"
  • Be specific: "Fix panic in catalog sync when controller restarts" not "Fix bug" or "Update catalog code"
  • Prefix with area if helpful: compute: , storage: , adapter: , sql:

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

@def- def- changed the title pg-cdc test: Fix certificate test pg-cdc test: Fix certificate generation process for tests Mar 27, 2026
@def- def- marked this pull request as ready for review March 27, 2026 11:43
@def- def- requested review from martykulma and teskje March 27, 2026 11:44
@def- def- enabled auto-merge (squash) March 27, 2026 11:45
martykulma
martykulma approved these changes Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@martykulma martykulma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@def- def- force-pushed the pr-fix-cert-test branch 2 times, most recently from 57ab575 to ba1b81e Compare March 27, 2026 12:28
@def- def- requested a review from a team as a code owner March 27, 2026 12:28
@def- def- force-pushed the pr-fix-cert-test branch from ba1b81e to 202acc8 Compare March 27, 2026 12:32
@def- def- disabled auto-merge March 27, 2026 12:34
@def- def- force-pushed the pr-fix-cert-test branch 2 times, most recently from ff2857b to d59fa01 Compare March 27, 2026 12:42
@def- def- requested a review from martykulma March 27, 2026 12:43
@def-
Copy link
Copy Markdown
Contributor Author

def- commented Mar 27, 2026

Had to change the approach, putting in private keys (even for testing) seemed horrible.

@def- def- enabled auto-merge (squash) March 27, 2026 12:46
@def- def- force-pushed the pr-fix-cert-test branch from d59fa01 to abd079c Compare March 27, 2026 13:47
@def-
pg-cdc test: Fix certificate test
499f3bf 
Follow-up to MaterializeInc#35487

Causing test failures in main, see for example: https://buildkite.com/materialize/test/builds/119386#019d2eee-d56c-4bd2-8d5e-409525b0a147

pg-cdc-ssl-ca-bundle.td:38:1: executing query failed: db error: ERROR: error performing TLS handshake: error:0A000086:SSL routines:tls_post_process_server_certificate:certificate verify failed:ssl/statem/statem_clnt.c:2091:: self-signed certificate in certificate chain: error:0A000086:SSL routines:tls_post_process_server_certificate:certificate verify failed:ssl/statem/statem_clnt.c:2091:: error:0A000086:SSL routines:tls_post_process_server_certificate:certificate verify failed:ssl/statem/statem_clnt.c:2091:
@def- def- force-pushed the pr-fix-cert-test branch from abd079c to 499f3bf Compare March 27, 2026 13:55
@def- def- merged commit 1ca9eba into MaterializeInc:main Mar 27, 2026
85 checks passed
@def- def- deleted the pr-fix-cert-test branch March 27, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antiguru antiguru antiguru approved these changes

@teskje teskje Awaiting requested review from teskje

@martykulma martykulma Awaiting requested review from martykulma

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@def- @antiguru @martykulma