storage,compute: rethink reconciliation [PART 1]#13680
Merged
benesch merged 1 commit intoJul 17, 2022
Merged
Conversation
Previously, reconciliation sat on *top* of storage/compute servers, and attempted to paper over commands and responses so that clients believed they were talking to a fresh server, while servers always believed they were talking to the originally-connected client. This introduced a lot of complicated logic and double bookkeeping. This commit pushes reconciliation logic into the storaged and computed servers. The servers are now aware of when a new client connects, and they simply ditch any state that was related to the old client. This tees us up for the last reconciliation task: garbage collecting sources and dataflows that newly-connected clients are not interested in. Touches #10549. Touches #12857.
frankmcsherry
approved these changes
Jul 17, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the prefix of #13526 that is ready for merge.
Motivation
Testing
Backward compatibility
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way) and therefore is tagged with aT-protobuflabel.Release notes
This PR includes the following user-facing behavior changes: