persist: panic instead of silent incorrectness on invalid usage#13618
Merged
danhhz merged 2 commits intoMaterializeInc:mainfrom Jul 18, 2022
Merged
persist: panic instead of silent incorrectness on invalid usage#13618danhhz merged 2 commits intoMaterializeInc:mainfrom
danhhz merged 2 commits intoMaterializeInc:mainfrom
Conversation
Contributor
Author
|
Paul mostly included you as an FYI. There's a lot of context you may not have yet on this, so don't feel the need to review (though it's welcome of course). |
aljoscha
approved these changes
Jul 14, 2022
Before this commit, if a shard's since was advanced beyond the frontier of some active listener, that listener could emit incorrect data (compaction would also have to be quite prompt). This would be an invalid usage by the persist user (the since shouldn't have been advanced that far), but it's better to panic then silently emit incorrect data. This doesn't seem to be happening in practice. Not bothering with a regression test because the way I found this was an upcoming branch that causes persist unit tests to deterministically fail.
4e8cbaf to
5f3a07f
Compare
2 tasks
c664f54 to
5808226
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, if a shard's since was advanced beyond the frontier
of some active listener, that listener could emit incorrect data
(compaction would also have to be quite prompt). This would be an
invalid usage by the persist user (the since shouldn't have been
advanced that far), but it's better to panic then silently emit
incorrect data. This doesn't seem to be happening in practice.
Not bothering with a regression test because the way I found this was an
upcoming branch that causes persist unit tests to deterministically
fail.
Motivation
Testing
Release notes
This PR includes the following user-facing behavior changes: