Fixed remote attachments parsing#17
Merged
ornithocoder merged 1 commit intoMastodonKit:masterfrom May 10, 2017
Merged
Conversation
While documentation states that `textURL` is not optional, it may be `null` in case of remote attachments. Earlier this case wasn't handled which caused remote attachments not being detected.
bbb73f4 to
37599d4
Compare
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 43 43
Lines 620 619 -1
=====================================
- Hits 620 619 -1
Continue to review full report at Codecov.
|
ornithocoder
approved these changes
May 10, 2017
Contributor
ornithocoder
left a comment
There was a problem hiding this comment.
Thanks @vhbit! Can you submit a change to the official mastodon API documentation? One of the reason I added that nullability column there is to find these cases where the values can be nullable. Thanks again!
Contributor
Author
|
Sure. It's mastodon/documentation#238 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While documentation states that
textURLis not optional, it may benullin case of remote attachments.Earlier this case wasn't handled which caused remote attachments not
being detected.