fix: avoid disabling reasoning for reasoning-capable summarizers#371
Merged
jalehman merged 1 commit intoApr 10, 2026
Merged
Conversation
Contributor
|
Thank yoU! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hi! This PR fixes an LCM summarizer edge case for reasoning-capable models.
If the initial summarizer request omits a reasoning setting, some provider compatibility layers can normalize that into a reasoning-disabled request. Some models do not support turning reasoning off, so the first request fails and only the retry succeeds.
I first noticed this with
openrouter/minimax/minimax-m2.7, but the issue is more general than one specific model.What changed
reasoningIfSupportedoption to the completion bridgereasoningvalues unchanged and give them priorityreasoningIfSupported: "low"on the initial requestWhy this approach
This keeps the fix narrow and model-aware.
It avoids a model-specific special case, preserves explicit caller intent, and does not force reasoning on models that do not support it.
Testing
npx vitest run test/index-complete-model-auth.test.ts test/summarize.test.ts test/lcm-summarizer-reasoning.test.tsThanks very much for taking a look.