Remove features not supported in plugin sandbox#780
Conversation
|
|
❌ The last analysis has failed. |
|
Thanks, that looks like a cool project! I'll see if I can switch it around to access this information in some other way rather than from the file system to avoid the try/catch approach, hopefully I'll be able to push a new change in the next few days. I also noticed you're using ILMerge to combine the MarkMpn.Sql4Cds.Engine and various other assemblies into your plugin - you might want to look into using a plugin package instead to avoid this. |
|
The other advantage of this change is that it fixes an issue when you use .net single file publishing as I was getting errors in this block of code with some stuff published this way. I have had no issues with pluginpackages including Sql4Cds other than the fact that lots of assemblies are included in the lib\net462 folder (this isn't all of the files!) 
Some undesirable assemblies are included (which block upload into dynamics), and I never found a way to filter them out, so post-process the nuget file to remove most of them. I do wonder whether the detail might be better done as a compile time setting rather than run time? The version of the dynamics environment has little value in the online world. |
|
Agreed, I'll be looking to build this in as assembly metadata at compile time in the next update. |
|
I believe the changes in #786 should address this, but please re-open it if you still have any problems with v10.4.4! |
|
Thank you! You're a superstar. |
The version retrieval code, touching the file system, broke the Sql4Cds engine when embedded into a plugin running inside the Dataverse sandbox.
The simplest fix of simply ignoring the error has been applied.
With these changes it now perfectly works inside the plugin sandbox environment and is used in a derivative project I have recently been working on - Sql4CdsApp.
Thank you so much for this wonderful tool! It's the nr 1 tool in my toolbox and I use it for everything, including bulk data updates and data migrations.