Add FLOOR function#747
Merged
Merged
Conversation
Owner
|
Thanks for this and the other related functions, that's great! I just want to check how the precision and scale of decimal values flow through this to ensure there aren't any surprises in subsequent calculations, I'll try to take a look into this over the next week or so. |
8db1091 to
d40fa57
Compare
Contributor
Author
|
Rebased all three PRs with proper overloads and extended DecimalPrecisionAttribute with an optional scale parameter to handle CEILING/FLOOR returning decimal(p, 0). |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
FLOORfunction which returns the largest integer less than or equal to the specified numeric expression.Changes
ExpressionFunctions.cs— six overloads covering all supported numeric types:int,bigint,decimal,float,money,realFunctionMetadata.cs— autocomplete/IntelliSense entryExpressionFunctionTests.cs— unit tests covering positive, negative, fractional, whole, and null inputsUsage