This repository was archived by the owner on Jul 12, 2020. It is now read-only.
Merged
Conversation
The `slugify()` method is taken from the source code of markdown-it-anchor@5.0.0[1], which MarkBind uses to generate anchor IDs. [1] - https://github.com/valeriangalliat/markdown-it-anchor/blob/v5.0.0/index.js
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Bug fix
Fixes MarkBind/markbind#413
What is the rationale for this request?
Anchor ID generation for vue-strap is different from MarkBind. It needs to be updated to match the one in MarkBind.
What changes did you make? (Give an overview)
Changed the anchor generation by following the implementation in
markbind-it-anchor@5.0.0.markbind-it-anchorused to use thestringspackage, which is why the original code forPanel.vueuses that as well. We are substituting it with the one found in version5.0.0because that is what theMarkBindside is currently using.Provide some example code that this change will affect:
Is there anything you'd like reviewers to focus on?
NIL
Testing instructions:
npm run build.vue-strap.min.jsto yourMarkBindasset/js.