Conversation
20ca545 to
b37e3c8
Compare
|
As discussed face-to-face: Running diff --git a/package-lock.json b/package-lock.json
index f4a7194..6f2e2dd 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -214,22 +214,6 @@
"default-require-extensions": "1.0.0"
}
},
+ "aproba": {
+ "version": "1.2.0",
+ "resolved": "https://registry.npmjs.org/aproba/-/aproba-1.2.0.tgz",
+ "integrity": "sha512-Y9J6ZjXtoYh8RnXVCMOU/ttDmk1aBjunq9vO0ta5x85WDQiQfUF9sIPBITdbiiIVcBo03Hi3jMxigBtsddlXRw==",
+ "optional": true
+ },
+ "are-we-there-yet": {
+ "version": "1.1.5",
+ "resolved": "https://registry.npmjs.org/are-we-there-yet/-/are-we-there-yet-1.1.5.tgz",
+ "integrity": "sha512-5hYdAkZlcG8tOLujVDTgCT+uPX0VnpAH28gWsLfzpXYm7wP6mp5Q/gYyR7YQ0cKVJcXJnl3j2kpBan13PtQf6w==",
+ "optional": true,
+ "requires": {
+ "delegates": "1.0.0",
+ "readable-stream": "2.3.3"
+ }
+ },
"argparse": {
"version": "1.0.9",Upon tracking down the packages, we found out that this is because, on Windows, On macOS, these are needed and requires upgrading, so Therefore, running on different platforms on the same code/commit does not always guarantee that the same Since these packages are needed by macOS, I think it would be good to take @luyangkenneth's |
npm install with npm 5.8.0
|
I have merged this PR so that everyone can receive the new copy of However, as @luyangkenneth also mentioned, the industry actually uses bots to maintain |
|
Oh, I forgot to credit @Xenonym in the commit message, sorry about that. :P |
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Other, please explain: Change our
package-lock.jsonto a sane stateWhat is the rationale for this request?
Refer to #756 for the discussion