Enhance Json Variable Doc with scope example#1208
Merged
ang-zeyu merged 2 commits intoMarkBind:masterfrom Jun 9, 2020
Merged
Conversation
Contributor
Author
|
Ready for review |
ang-zeyu
reviewed
May 3, 2020
docs/userGuide/syntax/variables.mbdf
Outdated
| ``` | ||
|
|
||
| Variables defined in JSON file will be scoped according to where it is being referenced. | ||
| Variables defined in JSON file will be scoped according to where it is being referenced. For json variables referenced in `variables.md` |
Contributor
There was a problem hiding this comment.
Suggested change
| Variables defined in JSON file will be scoped according to where it is being referenced. For json variables referenced in `variables.md` | |
| Variables defined in a JSON file will be scoped according to where it is being referenced. JSON variables referenced in `variables.md` |
docs/userGuide/syntax/variables.mbdf
Outdated
|
|
||
| Variables defined in JSON file will be scoped according to where it is being referenced. | ||
| Variables defined in JSON file will be scoped according to where it is being referenced. For json variables referenced in `variables.md` | ||
| would be globally scoped like other global variables in that file. On the other hand: |
Contributor
There was a problem hiding this comment.
Suggested change
| would be globally scoped like other global variables in that file. On the other hand: | |
| would be globally scoped like other global variables in that file. |
Contributor
|
Resolved a minor conflict and merged in the suggestions for now, do let me know if the suggestions weren't what you meant! |
ang-zeyu
approved these changes
Jun 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Documentation update
Resolves #1202
What is the rationale for this request?
Elaborate on how JSON variable is scoped.
What changes did you make? (Give an overview)
Added documentation.
Provide some example code that this change will affect:
N/A
Is there anything you'd like reviewers to focus on?
Clarity of documentation.
Testing instructions:
N/A
Proposed commit message: (wrap lines at 72 characters)
Enhance Json Variable Doc with scope example