Small fixes (updated bootstrap, fixed mismatched HTML tags, etc)#4
Merged
MarinX merged 9 commits intoMarinX:mainfrom Mar 7, 2025
Merged
Small fixes (updated bootstrap, fixed mismatched HTML tags, etc)#4MarinX merged 9 commits intoMarinX:mainfrom
MarinX merged 9 commits intoMarinX:mainfrom
Conversation
The `<script type="module">` is required for the inline script to execute *after* the rest of the page is loaded.
Bootstrap v5.3 supports multiple color schemes. However by default it doesn't support @media(prefers-color-scheme). So I went into the rabbit hole of "how to build a custom bootstrap version" and ended up overhauling a lot of this project, using PNPM for dependency management and Vite for building the scss/js and bundling. Somehow you can still build this with `make build`.
a9261b6 to
5eefd2d
Compare
The code may be slightly cursed, but it no longer rebuilds targets when not necessary.
5eefd2d to
cc75ea3
Compare
Contributor
Author
|
(fixed a typo where I used a |
Owner
|
damn, those are really small fixes 🤣 and thank you for the PR. |
Contributor
Author
|
I tried deploying it and realized I forgot to copy the favicon into dist (gonna fix it later, but you can see it at https://encrypt.lunareclipse.zone) |
Owner
|
Thank you @LunarEclipse363 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And by "small fixes" I mean:
@media(prefers-color-scheme)requires a bunch of extra JS (janky)...index.htmlthrough Prettier (opinionated but consistent code formatter)Makefileso you can keep runningmake buildand only the steps that have to be re-done will be re-done (the weird parts of the code that I wouldn't guess from skimming the gnu make manual are explained in comments)make helpwhich prints help for all the PHONY targets based on comments and it was just a fun random idea to implementindex.html(were</a>, should be</button>)vendor/before being bundled by Vite later on in the build processsrc/(index.htmletc.)src/public/(they get put in the website root,favicon.icoetc.)dist/(I followed the convention from one of the tools I used)package.json, I hope it's all correct, also that's another place that contains the package version nowindex.html, first look at the diff until the commit that applies Prettier and then look at the diff after the commit that applies Prettier<head>and is now also kinda obsolete because all scripts are moved intosrc/main.jsindex.htmland put intosrc/main.js, and Vite does some magic with that to bundle it into one output JS file that works (I don't fully understand JS bundlers honestly, I used Vite because bootstrap tells you how to use it to get a customized build)pnpm-lock.yamlis autogenerated by PNPM (afaik you're supposed to include lock files in source control for binary software).gitignoreto match all the above changespnpm run formatscript for running prettier on the relevant files (JS/HTML/SCSS)pnpm run dev)