deepfreeze must not modify original object#97
Merged
Marco-Sulla merged 3 commits intoMarco-Sulla:masterfrom Apr 13, 2024
Merged
deepfreeze must not modify original object#97Marco-Sulla merged 3 commits intoMarco-Sulla:masterfrom
deepfreeze must not modify original object#97Marco-Sulla merged 3 commits intoMarco-Sulla:masterfrom
Conversation
3 tasks
Owner
|
The intent of deepfreeze is to freeze all nested object, as per docs. See also #96 (comment) |
Owner
|
Excuse me, the question was not clear. I see the code and caught the point. |
deepfrozen should not modify original objectdeepfreeze must not modify original object
Contributor
Author
|
@Marco-Sulla thanks for taking a second look!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test and corrects the deepfreeze implementation for nested
dict.Resovles #96