Prefer forward conversion if registered#95
Merged
Marco-Sulla merged 5 commits intoMarco-Sulla:masterfrom Jan 24, 2024
Merged
Conversation
When a forward conversion is registered to getFreezeConversionMap(), that explicit conversion is now preferred over the (implicit) inverse of a (backward) conversion registered to getFreezeConversionInverseMap(). This behavior is consistent with the preexisting preference for explicit forward conversion of certain simple types(_freeze_types_plain) and non- iterables and strings (i.e., excluded by isIterableNotString()).
Owner
|
Uh, a subtle bug, good. |
Owner
|
I thought you add a test with MappingProxy, instead you preferred a more robust solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a forward conversion is registered to getFreezeConversionMap(), that explicit conversion is now preferred over the (implicit) inverse of a (backward) conversion registered to getFreezeConversionInverseMap(). This behavior is consistent with the preexisting preference for explicit forward conversion of certain simple types (_freeze_types_plain) and non-iterables and strings (i.e., excluded by isIterableNotString()).
The modified behavior can be seen in the example below:
As a practical use case, I'm currently working on a project in which I'd like to use deepfreeze() to ensure that a nested mappingproxy is hashable.