Fix python implementation pickling#91
Conversation
|
Excuse me, but why you have renamed also PS: I added a build and test for the pure py implementation in the pipeline, so I'm going to remove the pure py tests from the C extension tests. Wait for it. |
I explained this in the PR description. Existing files that have been pickled on python 3.11 mention Moving the python implementation and setting up |
7db1d83 to
729700a
Compare
Ok, but what if I pickle At this point, is it not much simpler to remove |
If you pickle |
This PR is split into two commits for easier review since git doesn't correctly show the rename operation on
core.py😞 .The first moved the pure python implementation to
_frozendictpyso thatcore.pycan become a compatibility wrapper, but makes no other changes. This allows existing pickles that mentionfrozendict.core.frozendictto correctly depickle as the native implementation in the future on python 3.11.The second implements the fix for #87.