Skip to content

Fix union of frozendict for python implementation#89

Merged
Marco-Sulla merged 2 commits intoMarco-Sulla:masterfrom
apmorton:am/fix-or
Nov 18, 2023
Merged

Fix union of frozendict for python implementation#89
Marco-Sulla merged 2 commits intoMarco-Sulla:masterfrom
apmorton:am/fix-or

Conversation

@apmorton
Copy link
Copy Markdown
Contributor

Fixes #84

Copy link
Copy Markdown
Owner

@Marco-Sulla Marco-Sulla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good and will fix things for Python 3.9+, but this will not fix the wrong frozendict_or function.

@Marco-Sulla
Copy link
Copy Markdown
Owner

Please ignore my previous comment, I was a little tired and I didn't review your change carefully.

@Marco-Sulla Marco-Sulla reopened this Nov 18, 2023
@Marco-Sulla Marco-Sulla dismissed their stale review November 18, 2023 19:35

I am a cow.

@Marco-Sulla Marco-Sulla merged commit db44acb into Marco-Sulla:master Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Union of frozendict and frozendict results in dict

2 participants