fixed memory leak on hash

Marco Sulla · Marco Sulla · commit 8def42ca45c9 · 2022-04-20T22:13:00.000+02:00
diff --git a/frozendict/VERSION b/frozendict/VERSION
@@ -1 +1 @@
-2.3.1
+2.3.2
diff --git a/frozendict/src/3_10/frozendictobject.c b/frozendict/src/3_10/frozendictobject.c
@@ -668,13 +668,15 @@ static Py_hash_t frozendict_hash(PyObject* self) {
         }
         else {
             PyObject* frozen_items = PyFrozenSet_New(frozen_items_tmp);
+            Py_DECREF(frozen_items_tmp);
 
             if (frozen_items == NULL) {
                 hash = MINUSONE_HASH;
                 save_hash = 0;
             }
             else {
                 hash = PyFrozenSet_Type.tp_hash(frozen_items);
+                Py_DECREF(frozen_items);
             }
         }
 
diff --git a/frozendict/src/3_6/frozendictobject.c b/frozendict/src/3_6/frozendictobject.c
@@ -680,13 +680,15 @@ static Py_hash_t frozendict_hash(PyObject* self) {
         }
         else {
             PyObject* frozen_items = PyFrozenSet_New(frozen_items_tmp);
+            Py_DECREF(frozen_items_tmp);
 
             if (frozen_items == NULL) {
                 hash = MINUSONE_HASH;
                 save_hash = 0;
             }
             else {
                 hash = PyFrozenSet_Type.tp_hash(frozen_items);
+                Py_DECREF(frozen_items);
             }
         }
 
diff --git a/frozendict/src/3_7/frozendictobject.c b/frozendict/src/3_7/frozendictobject.c
@@ -674,13 +674,15 @@ static Py_hash_t frozendict_hash(PyObject* self) {
         }
         else {
             PyObject* frozen_items = PyFrozenSet_New(frozen_items_tmp);
+            Py_DECREF(frozen_items_tmp);
 
             if (frozen_items == NULL) {
                 hash = MINUSONE_HASH;
                 save_hash = 0;
             }
             else {
                 hash = PyFrozenSet_Type.tp_hash(frozen_items);
+                Py_DECREF(frozen_items);
             }
         }
 
diff --git a/frozendict/src/3_8/frozendictobject.c b/frozendict/src/3_8/frozendictobject.c
@@ -674,13 +674,15 @@ static Py_hash_t frozendict_hash(PyObject* self) {
         }
         else {
             PyObject* frozen_items = PyFrozenSet_New(frozen_items_tmp);
+            Py_DECREF(frozen_items_tmp);
 
             if (frozen_items == NULL) {
                 hash = MINUSONE_HASH;
                 save_hash = 0;
             }
             else {
                 hash = PyFrozenSet_Type.tp_hash(frozen_items);
+                Py_DECREF(frozen_items);
             }
         }
 
diff --git a/frozendict/src/3_9/frozendictobject.c b/frozendict/src/3_9/frozendictobject.c
@@ -674,13 +674,15 @@ static Py_hash_t frozendict_hash(PyObject* self) {
         }
         else {
             PyObject* frozen_items = PyFrozenSet_New(frozen_items_tmp);
+            Py_DECREF(frozen_items_tmp);
 
             if (frozen_items == NULL) {
                 hash = MINUSONE_HASH;
                 save_hash = 0;
             }
             else {
                 hash = PyFrozenSet_Type.tp_hash(frozen_items);
+                Py_DECREF(frozen_items);
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -668,13 +668,15 @@ static Py_hash_t frozendict_hash(PyObject* self) {`
`668`	`668`	`}`
`669`	`669`	`else {`
`670`	`670`	`PyObject* frozen_items = PyFrozenSet_New(frozen_items_tmp);`
	`671`	`+ Py_DECREF(frozen_items_tmp);`
`671`	`672`
`672`	`673`	`if (frozen_items == NULL) {`
`673`	`674`	`hash = MINUSONE_HASH;`
`674`	`675`	`save_hash = 0;`
`675`	`676`	`}`
`676`	`677`	`else {`
`677`	`678`	`hash = PyFrozenSet_Type.tp_hash(frozen_items);`
	`679`	`+ Py_DECREF(frozen_items);`
`678`	`680`	`}`
`679`	`681`	`}`
`680`	`682`
Original file line number	Diff line number	Diff line change
`@@ -680,13 +680,15 @@ static Py_hash_t frozendict_hash(PyObject* self) {`
`680`	`680`	`}`
`681`	`681`	`else {`
`682`	`682`	`PyObject* frozen_items = PyFrozenSet_New(frozen_items_tmp);`
	`683`	`+ Py_DECREF(frozen_items_tmp);`
`683`	`684`
`684`	`685`	`if (frozen_items == NULL) {`
`685`	`686`	`hash = MINUSONE_HASH;`
`686`	`687`	`save_hash = 0;`
`687`	`688`	`}`
`688`	`689`	`else {`
`689`	`690`	`hash = PyFrozenSet_Type.tp_hash(frozen_items);`
	`691`	`+ Py_DECREF(frozen_items);`
`690`	`692`	`}`
`691`	`693`	`}`
`692`	`694`
Original file line number	Diff line number	Diff line change
`@@ -674,13 +674,15 @@ static Py_hash_t frozendict_hash(PyObject* self) {`
`674`	`674`	`}`
`675`	`675`	`else {`
`676`	`676`	`PyObject* frozen_items = PyFrozenSet_New(frozen_items_tmp);`
	`677`	`+ Py_DECREF(frozen_items_tmp);`
`677`	`678`
`678`	`679`	`if (frozen_items == NULL) {`
`679`	`680`	`hash = MINUSONE_HASH;`
`680`	`681`	`save_hash = 0;`
`681`	`682`	`}`
`682`	`683`	`else {`
`683`	`684`	`hash = PyFrozenSet_Type.tp_hash(frozen_items);`
	`685`	`+ Py_DECREF(frozen_items);`
`684`	`686`	`}`
`685`	`687`	`}`
`686`	`688`