Refactor IMapper.From to return interface #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@gritcsenko The master branch should be in better shape now with EF Core 6.0. Could you please sync your branch and see if the build errors have gone away? And if so, run the tests as well? Thanks! :) |
Contributor
|
@gritcsenko I synced the fork and fixed a few build errors. Everything now builds and all tests are passing. Can you take a look at my changes and verify that they are good? |
Contributor
Author
@andrerav Thanks for the update. Everything looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
IMapper.From<TSource>()to return new interfaceITypeAdapterBuilder<TSource>instead of concrete class.FYI: Mapster.EF6 & Mapster.EFCore uses outdated package version and causes compilation errors in Mapster.EFCore.Tests and Sample.AspNetCore
Closes #376