Skip to content

Double clicking tree item starts download#103

Merged
MakovWait merged 2 commits intoMakovWait:mainfrom
EthanGrahn:feat/double-click-install
Oct 2, 2024
Merged

Double clicking tree item starts download#103
MakovWait merged 2 commits intoMakovWait:mainfrom
EthanGrahn:feat/double-click-install

Conversation

@EthanGrahn
Copy link
Copy Markdown
Contributor

This uses the native item_activated() signal of the Tree element. The handle_button_clicked function does not currently make use of the passed in values, therefore passing in null does that have an effect. If that functionality changes, this should be redesigned. I'm open to making any requested changes!

Resolves #89

@MakovWait
Copy link
Copy Markdown
Owner

MakovWait commented Oct 2, 2024

it would be really nice if the appropriate method (i.e. handle_item_activated) were declared here

and implemened in all subtypes that may somehow react on it:
class RemoteTreeItemTuxFamily extends RemoteEditorsTreeDataSource.Item:

class GithubAssetItem extends GithubItemBase:

class GithubItemBase extends RemoteEditorsTreeDataSource.Item:

@EthanGrahn
Copy link
Copy Markdown
Contributor Author

I refactored to make those changes. Let me know how it looks!

@MakovWait
Copy link
Copy Markdown
Owner

it looks gorgeous! thanks!

@MakovWait MakovWait merged commit c152061 into MakovWait:main Oct 2, 2024
@EthanGrahn EthanGrahn deleted the feat/double-click-install branch October 2, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double click to download editor

2 participants