fix(ui): sync settings forms via react-hook-form values to stop render loop#2947
Merged
Conversation
…r loop The Emby, Jellyfin and Servarr settings forms reset the form from loaded settings inside a useEffect keyed on the query result. When that data reference is unstable, the effect re-fires every render and loops until the vitest worker exhausts memory and is SIGTERM'd — which is what was failing the test job. Use react-hook-form's `values` option instead: it deep-compares and keeps the form in sync without an effect. Also stop ts-jest from re-transforming the prebuilt @maintainerr/contracts dist output, removing the compiler warning flood on every server test run.
Contributor
|
🎉 This PR is included in version 3.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Emby, Jellyfin and Servarr settings forms reset from loaded settings inside a
useEffectkeyed on the query result. When that data reference is unstable, the effect re-fires every render and loops until the vitest worker exhausts memory and is SIGTERM'd — the failure in the test job. Replaced with react-hook-form'svaluesoption, which deep-compares and removes the effect.Also stops ts-jest from re-transforming the prebuilt
@maintainerr/contractsdist output, removing the compiler warning flood on server test runs.The remaining "worker failed to exit gracefully" warning is left intentionally and tracked in #2946.