Fix/manual collections improvements and fixes#2657
Closed
Simon-Eklundh wants to merge 5 commits into
Closed
Conversation
Simon-Eklundh
commented
Apr 11, 2026
Comment on lines
+170
to
+181
| /** | ||
| * this needs help from a plex programmer | ||
| * | ||
| * @param id | ||
| * @param libraryId | ||
| * @returns | ||
| */ | ||
| async itemIsInLibrary(id: string, libraryId: string): Promise<boolean> { | ||
| console.log ("not sure what to do about this") | ||
| return false | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
this is currently unused, but since it's in the interface it really should do "something"
(it does stuff for jellyfin)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & Design
This pr is likely a combination of #2616
and a few fixes to how collections are treated.
It only actively does changes to jellyfin logic, but adds to the mediaserver interface for both jellyfin and plex.
the plex aspect will likely need a look.
Please include:
Related issue
If this pull request addresses an issue, please link to it here (e.g.,
Fixes #123).AI-Assisted Development
If you used AI tools (e.g. ChatGPT, Copilot, Claude) while working on this PR, please
Checklist
How to test
Please describe the steps to test your changes, including any setup required.
Additional context
Add any other context about the pull request here, such as screenshots, logs, or relevant links.