Tweaked xmlns prefix to match previous automatic prefix#278
Merged
punker76 merged 1 commit intoMahApps:developfrom Oct 2, 2021
Merged
Tweaked xmlns prefix to match previous automatic prefix#278punker76 merged 1 commit intoMahApps:developfrom
punker76 merged 1 commit intoMahApps:developfrom
Conversation
|
|
Member
|
@jizc Thank you for this. Yes, I think it was a mistake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
I changed the
XmlnsPrefixfromiconpackstoiconPacks.Why?
Before
XmlnsPrefixwas added to theAssemblyInfo, VS automatically usediconPacksas the prefix. As we have been using this icon pack for years, this means our code base has hundreds of uses of the previous prefix.Any new uses now automatically adds the new prefix, meaning we will have different prefixes in different files for the same package. This causes issues when copying XAML between files that are using different prefixes.
Another annoying thing is that out-of-the-box ReSharper views the new prefix as a typo. Meaning we'll need to either keep renaming the prefix to the old prefix in every new file, or add
iconpacksto the custom dictionary. The latter is of course the easiest, but feels unnecessary.For these reasons, in my opinion, the best solution is to revert back to the previous prefix.