Improve IconPacks Browser with new features by timunie · Pull Request #232 · MahApps/MahApps.Metro.IconPacks

timunie · 2020-10-04T19:44:14Z

What changed?

This is a proposal for a different IconPacksBrowser. For now not all Features are implemented as it is more meant as a proposal at this moment. Currently this changed:

Use HamburgerMenu instead of TabControl
Use a PreviewPane to display, adjust and (later) export the selected Icon
More space for Icons if needed
DataTemplate is now more "generic". This should lead to less effort if there are more IconPacks added

Screenshots

Closed Issues

Closes #230
Closes #57
Closes #12
Closes #51

punker76 · 2020-10-08T09:16:24Z

@timunie appveyor shows this error

C:\projects\mahapps-metro-iconpacks\src\MahApps.Metro.IconPacks.Browser\MainWindow.xaml(338,11): error MC3000: 'The 'Canvas' start tag on line 315 position 18 does not match the end tag of 'DataTemplate'. Line 338, position 11.' XML is not valid.

timunie · 2020-10-08T14:10:49Z

It did work and compile, but now the XAML of the MainWindow is totally rubbish. I have no idea what happend here. But if you are interested in this, I'll double-check. If you want to stick with the current design we can also close this PR.

@punker76 please give me a short 👍 or 👎 . 🙏

punker76 · 2020-10-08T14:58:05Z

Here some thoughts (suggestions):

"Filter by" should be always visible, maybe on the right top on the title header of the showing icon page
Save as Svg could be difficult, because some paths are inverted (and not the original one)

timunie · 2020-10-09T06:22:16Z

Hi @punker76

Thank you for the suggestions. The issue was caused by the last rebase, I'll fix this when I have some time for it. Moving the searchtextbox to the right was also something I was thinking about.

Save as Svg could be difficult, because some paths are inverted (and not the original one)

🤔 Let's see if there is a way or not. Do you have an example which icon is inverted? I would like to use this for testing

Info: I would like to use the ColorPicker MahApps/MahApps.Metro#3930 to let the user select the colors. So I would also like to wait for this before you merge this PR.

Nevertheless I can make smaller PR for useful features. Especially the DataTemplateSelector seems to be very handy. Should I make a separate PR for this?

Happy coding
Tim

Insire · 2020-10-09T16:22:04Z

Do you have an example which icon is inverted?

iirc the fontawesome icons are inverted

timunie · 2020-11-07T20:23:34Z

@punker76 do you mean the following image by

Save as Svg could be difficult, because some paths are inverted (and not the original one)

If yes, I think I know how to export the data in the right direction. We "just" have to translate the LayoutTransform-Matrix to svg.

timunie · 2020-11-09T13:14:51Z

@punker76 do you mean the following image by

Save as Svg could be difficult, because some paths are inverted (and not the original one)

If yes, I think I know how to export the data in the right direction. We "just" have to translate the LayoutTransform-Matrix to svg.

Here are some exported examples:
Example-Export.zip

- Iconpacks will always be in alphabetical order - More Space for Icons - More Space for an export panel

- The DataTemplate is now selected in code behind. This is more generic and needs less adjustments for new IconPacks

Do more work. Do more Work Implement Search- Shortcut Ctrl+F

Smoothing Expander Animation

…e own NullToUnsetValueConverter The wrong template binding raises some errors which results in bad performance.

I think this is more readable

- Added Header with detailed information - Imporve Export - Use Template for Bitmap as well - Improve ColorPicker usage

timunie · 2020-12-04T14:30:03Z

Hi @punker76,

should we offer support for custom ExportTemplates and CopyToClipboardTemplates? That way the user could modify the template and for example copy the icon with Width, Height or Foreground set.

Happy coding and a nice weekend
Tim

Templates

timunie · 2020-12-12T12:36:45Z

Hi @punker76 ,

I think I am good to go. Functions which are now implemented are:

other design
search via [Ctrl]+[F]
configure preview size and color
Export icon to svg, xaml and image
Display more icon information
Support for theming
Support for custom Export and CopyToClipboard-Templates.

I which everyone happy coding, happy x-mas 🎄 and a happy new year 🎆
Tim

punker76 · 2021-09-10T08:55:09Z

finally

punker76 · 2021-09-10T09:16:36Z

@timunie your changes have been merged, thanks for your contribution 👍

timunie force-pushed the HamburgerMenuProposal branch from d328904 to f2d62cf Compare October 6, 2020 18:03

timunie force-pushed the HamburgerMenuProposal branch from 019fa7f to f14ce61 Compare October 28, 2020 18:28

timunie force-pushed the HamburgerMenuProposal branch from c77bbf0 to a8ba5af Compare November 13, 2020 08:57

timunie added 20 commits November 17, 2020 13:44

Use HamburgerMenu

655de00

- Iconpacks will always be in alphabetical order - More Space for Icons - More Space for an export panel

Add preview pane

24ba93d

Dynamic DataTemplate and improved PreviewPane

55ac7be

- The DataTemplate is now selected in code behind. This is more generic and needs less adjustments for new IconPacks

Resolved building issues after Rebase

f71462d

Add SearchTextBox

1cf0fe5

Do more work. Do more Work Implement Search- Shortcut Ctrl+F

Implement ListViewStyle for Navigation

651ac69

ListBox

6a8f4ae

Alternative UnifromGrid-like TilePanel

040d3f0

Ripple Effect

657f36d

Win10 like ScrollViewer

3b6c47d

Improving Header design

5b69276

Improvements

1cc65bd

ResizeableExpander

4b4b951

Thumb Stlye

63f818d

Animate Sidebar

eb2c629

Smoothing Expander Animation

Improved virtualization performance

afcb1cb

ClipboardButtons desing was broken

970d494

Implementing SideBar

2113188

Improve CopyToClipboard-Actions

7798992

Some style improvements

6b7590f

IconTemplateSelector: Fix template binding to width and height and us…

a039fce

…e own NullToUnsetValueConverter The wrong template binding raises some errors which results in bad performance.

punker76 force-pushed the HamburgerMenuProposal branch from def72eb to a039fce Compare November 17, 2020 12:45

timunie added 7 commits November 18, 2020 20:22

Add experimental XAML Export support

0518d75

Add experimental UWP Export

448c7ad

experimental BitmapExport

8dbf7d5

Fix Bitmap-Export

d0ee017

change {{parameter}} to @parameter

7dd4a5a

I think this is more readable

Add ColorPicker

7c23698

Improve Export further

e4f314c

- Added Header with detailed information - Imporve Export - Use Template for Bitmap as well - Improve ColorPicker usage

timunie added 5 commits December 5, 2020 22:31

Add Theming support

e32c808

More Theming

6320ca7

Load Clipboard-String from templates folder and allow for custom

397a714

Templates

Some UI Improvements

d6d002b

Some UI Improvements

93f4fd6

timunie force-pushed the HamburgerMenuProposal branch from 2594492 to 93f4fd6 Compare December 10, 2020 11:07

Use try-catch and display a message via DialogCoordinator if failed.

df6d62f

timunie changed the title ~~[WIP][RFC] HamburgerMenu proposal~~ [RFC] HamburgerMenu proposal Dec 12, 2020

timunie mentioned this pull request Apr 3, 2021

How to convert a PackIconMarkup to a Geometry object? #256

Closed

punker76 added 2 commits September 10, 2021 09:59

Use PackIconControl instead the IconTemplateSelector

d9210b5

Update build config

379d40f

punker76 changed the title ~~[RFC] HamburgerMenu proposal~~ Improve IconPacks Browser with new features Sep 10, 2021

punker76 added the Feature Request label Sep 10, 2021

punker76 added 2 commits September 10, 2021 10:38

Minor tweaks

00c5e97

XamlStyler

ef91288

punker76 merged commit b4afcf9 into MahApps:develop Sep 10, 2021

timunie deleted the HamburgerMenuProposal branch September 12, 2021 12:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve IconPacks Browser with new features#232

Improve IconPacks Browser with new features#232
punker76 merged 40 commits intoMahApps:developfrom
timunie:HamburgerMenuProposal

timunie commented Oct 4, 2020 •

edited by punker76

Loading

Uh oh!

punker76 commented Oct 8, 2020

Uh oh!

timunie commented Oct 8, 2020

Uh oh!

punker76 commented Oct 8, 2020

Uh oh!

timunie commented Oct 9, 2020

Uh oh!

Insire commented Oct 9, 2020 •

edited

Loading

Uh oh!

timunie commented Nov 7, 2020

Uh oh!

timunie commented Nov 9, 2020

Uh oh!

timunie commented Dec 4, 2020

Uh oh!

timunie commented Dec 12, 2020

Uh oh!

punker76 commented Sep 10, 2021

Uh oh!

punker76 commented Sep 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Conversation

timunie commented Oct 4, 2020 • edited by punker76 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed?

Screenshots

Closed Issues

Uh oh!

punker76 commented Oct 8, 2020

Uh oh!

timunie commented Oct 8, 2020

Uh oh!

punker76 commented Oct 8, 2020

Uh oh!

timunie commented Oct 9, 2020

Uh oh!

Insire commented Oct 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

timunie commented Nov 7, 2020

Uh oh!

timunie commented Nov 9, 2020

Uh oh!

timunie commented Dec 4, 2020

Uh oh!

timunie commented Dec 12, 2020

Uh oh!

punker76 commented Sep 10, 2021

Uh oh!

punker76 commented Sep 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

timunie commented Oct 4, 2020 •

edited by punker76

Loading

Insire commented Oct 9, 2020 •

edited

Loading