Adding x:Shared="False" to MahApps.TextBox.ContextMenu#3990
Merged
punker76 merged 1 commit intoMahApps:developfrom Dec 2, 2020
lipchev:TextBox.ContextMenu_MemoryLeak
Merged
Adding x:Shared="False" to MahApps.TextBox.ContextMenu#3990punker76 merged 1 commit intoMahApps:developfrom lipchev:TextBox.ContextMenu_MemoryLeak
punker76 merged 1 commit intoMahApps:developfrom
lipchev:TextBox.ContextMenu_MemoryLeak
Conversation
Member
|
@lipchev thx again! your changes have been merged, thanks for your contribution 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made to improve this project
Added
x:Shared="False"to the context menu (cut/copy/paste), used for all text-box controls.Unit test
none
Additional context
There seems to be a lot of confusion about the sharing of context menus on the internet:
My guess is that it probably has to do with something in the style- as it the leak doesn't grow up in instances, it's one per control type (I think).
Either that or it's the shared RoutedCommands (can there be a problem with those being shared!?)
If anyone understands the root cause here, I'd be curious to know..
Closed Issues
Closes #3989