Skip to content

Conversation

@KristjanESPERANTO
Copy link
Collaborator

@KristjanESPERANTO KristjanESPERANTO commented Sep 15, 2025

Since receiving a security warning about axios in node-ical (https://github.com/MagicMirrorOrg/MagicMirror/security/dependabot/70), I've created a pull request to remove axios from node-ical — it was accepted and we now have a new version 🙂

@KristjanESPERANTO KristjanESPERANTO marked this pull request as draft September 15, 2025 20:29
@KristjanESPERANTO
Copy link
Collaborator Author

KristjanESPERANTO commented Sep 15, 2025

I think the tests are failing because of the jsdom update. I'm searching for a solution 🙂

@KristjanESPERANTO
Copy link
Collaborator Author

KristjanESPERANTO commented Sep 15, 2025

jsdom v27 broke animation-name assertions in tests/e2e/animateCSS_spec.js. I replace them with class polling. And additionally added a negative assertion. Test green again 😃

@KristjanESPERANTO KristjanESPERANTO marked this pull request as ready for review September 15, 2025 21:43
@khassel khassel merged commit 777b49c into MagicMirrorOrg:develop Sep 15, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants