Skip to content

chore: use prettier --write --ignore-unknown in lint-staged to avoid errors on unsupported files #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rejas merged 2 commits into from
Sep 11, 2025
Merged

chore: use prettier --write --ignore-unknown in lint-staged to avoid errors on unsupported files #3888

rejas merged 2 commits into from
Sep 11, 2025

Conversation

@KristjanESPERANTO
Copy link
Collaborator

@KristjanESPERANTO KristjanESPERANTO commented Sep 11, 2025 •
edited
Loading

This prevents prettier from failing when lint-staged passes unknown/binary files, making the pre-commit hook more robust.

In concrete terms this could happen, when we, for example, add a new PNG file. Since we rarely do this, it has not been noticed so far.

This is recommended when using asterisk: https://github.com/lint-staged/lint-staged#automatically-fix-code-style-with-prettier-for-any-format-prettier-supports

before

$ npx lint-staged <-- after staging a new PNG file
✔ Backed up original state in git stash (c3247d4b)
✔ Hiding unstaged changes to partially staged files...
⚠ Running tasks for staged files...
  ❯ package.json — 2 files
    ❯ * — 2 files
      ✖ prettier --write [FAILED]
    ↓ *.js — no files
    ↓ *.css — no files
↓ Skipped because of errors from tasks.
↓ Skipped because of errors from tasks.
✔ Reverting to original state because of errors...
✔ Cleaning up temporary files...

✖ prettier --write:
[error] No parser could be inferred for file "~/MagicMirror/test.png".
...

after

$ npx lint-staged <-- after staging a new PNG file
✔ Backed up original state in git stash (0c3fe285)
✔ Running tasks for staged files...
✔ Applying modifications from tasks...
✔ Cleaning up temporary files...

@KristjanESPERANTO
chore: use prettier --write --ignore-unknown in lint-staged to av…
b42c41e 
…oid errors on unsupported files

Prevents Prettier from failing when lint-staged passes unknown/binary files, making the pre-commit hook more robust.

This is recommended when using asterisk: https://github.com/lint-staged/lint-staged#automatically-fix-code-style-with-prettier-for-any-format-prettier-supports
@KristjanESPERANTO
Copy link
Collaborator Author

KristjanESPERANTO commented Sep 11, 2025

By the way: It's actually somewhat good that we didn't have it before. Otherwise we wouldn't be formatting the njk files now – see #3887 😃

@rejas
Copy link
Collaborator

rejas commented Sep 11, 2025 •
edited
Loading

By the way: It's actually somewhat good that we didn't have it before. Otherwise we wouldn't be formatting the njk files now – see #3887 😃

thats the only downside of this PR: we would need to manually run prettier to find these un-linted file extension

@rejas rejas merged commit d81386f into MagicMirrorOrg:develop Sep 11, 2025
9 checks passed
@KristjanESPERANTO KristjanESPERANTO deleted the lint-staged-prettier branch September 11, 2025 16:47
@KristjanESPERANTO KristjanESPERANTO mentioned this pull request Sep 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rejas rejas rejas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KristjanESPERANTO @rejas