refactor: optimize system information logging #3843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- feat: include MagicMirror version - refactor: use more variables to get the string array less complex - refactor: get `installedNodeVersion` from si.versions (with that it was possible to drop the import of `execSync`)
rejas
approved these changes
Jul 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally to #3839 I did some rework on the system logging.
installedNodeVersionfrom si.versions (with that it was possible to drop the import ofexecSync)used nodewas always the same as the installed one. Since Electron comes with its own node version, this can differ. This is now shown correctly (again?) with the use ofprocess.version.I think these changes make the code easier to understand and therefore easier to maintain. Except for showing the MM version there is no big difference for the user.
before
after