Fixtestcase calendar testcase failure #3596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
can someone restart this as I changed the base branch while it was completing |
Collaborator
Author
|
can someone restart this as I changed the base branch |
Collaborator
|
AFAIS the helper is not working (anymore) so every (electron) test running with a specific date does not run with this date but uses today. So main problem is to fix the helper or find another solution because other tests will fail too in the future. This is only a hotfix to get the tests running and should be reverted when the main problem is solved. Will merge this and open an issue for the main problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix calendar testcase failing after date change (exposes helper failure)