Review config_check.js #3545
Merged
Review config_check.js #3545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove superfluous colors in Log.error - invert negative if - update ESLint env - use camel case variable name - optimize Log strings
rejas
approved these changes
Sep 18, 2024
Collaborator
|
why is this the only acceptable answer? I don't like the lack of visibility of the variable use |
Collaborator
Author
Sorry, I don't understand this question. What do you mean by answer?
What editor do you use? I think even in editors without syntax highlighting the variables in template literals are well recognizable by the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only details changes. No functional changes.