Skip to content

Conversation

@bugsounet
Copy link
Contributor

updatenotification:

allow force scanning with SCAN_UPDATES notification from other modules

@codecov-commenter
Copy link

Codecov Report

Merging #3127 (1bfbc00) into develop (e985e99) will increase coverage by 0.06%.
The diff coverage is 48.14%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop    #3127      +/-   ##
===========================================
+ Coverage    25.55%   25.62%   +0.06%     
===========================================
  Files           53       53              
  Lines        11464    11479      +15     
===========================================
+ Hits          2930     2941      +11     
- Misses        8534     8538       +4     
Impacted Files Coverage Δ
...s/default/updatenotification/updatenotification.js 0.00% <0.00%> (ø)
modules/default/updatenotification/node_helper.js 81.60% <68.42%> (+3.68%) ⬆️

@rejas
Copy link
Collaborator

rejas commented Jun 18, 2023

looks innocent enough for a quick merge :-) sorry for not going through the animate stuff yet, this takes more concentration :-(

@rejas rejas merged commit c1850f2 into MagicMirrorOrg:develop Jun 18, 2023
@rejas
Copy link
Collaborator

rejas commented Jun 18, 2023

Could you also create a PR for adding these notifications to the docs?

@bugsounet
Copy link
Contributor Author

Ok, i will take a look for prepare docs for all my stuff (commited or not)

@bugsounet
Copy link
Contributor Author

@rejas : have you already had the case locally that the e2e test suite failed (npm run test:e2e) and without touching anything, by relaunching npm run test:e2e it works?
I got it twice (even with the branch master, naturally without any 3rd party modules)

@rejas
Copy link
Collaborator

rejas commented Jun 18, 2023

@rejas : have you already had the case locally that the e2e test suite failed (npm run test:e2e) and without touching anything, by relaunching npm run test:e2e it works?

yes, the tests fail sometimes without any good reason. maybe some timing issues or whatever, we couldnt find it out yet. any help there would be greatly appreciated

@bugsounet bugsounet deleted the remoteForceCheckUpdate branch September 8, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants