Fix async node_helper stopping electron start #3021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 22, 2023 08:44
otherwise electron calls its init functions even though the config isnt loaded yet
Codecov Report
@@ Coverage Diff @@
## develop #3021 +/- ##
===========================================
+ Coverage 21.76% 21.84% +0.08%
===========================================
Files 52 52
Lines 11441 11442 +1
===========================================
+ Hits 2490 2500 +10
+ Misses 8951 8942 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
khassel
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Async node_helper dont have to finish immediately in loadModules. So the start callback in the app.js with the config isnt called for some time. But the electron ready event can already be fired in the meantime.
This lead to the electron app starting but without a config (which is provded by the node_helper callback) therefor crashing.
This PR fixes #2487 by moving the callback call out of the loadModules block, therefor the config is provided in time.
If any new async node_helper doesnt like this, we will see it :-)