Refresh the Calendar DOM every minute #3016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps relative dates accurate when the calendar's fetch frequency is much larger than a minute. As fetching incurs network traffic and load on servers and most calendars don't update that often, simply refreshing locally is enough.
rejas
reviewed
Jan 19, 2023
rejas
reviewed
Jan 19, 2023
modules/default/calendar/calendar.js
Outdated
| // Override start method. | ||
| start: function () { | ||
| const ONE_SECOND = 1000; // 1,000 milliseconds | ||
| const ONE_MINUTE = ONE_SECOND * 60; |
Collaborator
There was a problem hiding this comment.
const ONE_MINUTE = 60000;
is clear enough :-)
Contributor
Author
There was a problem hiding this comment.
This was in line with the rest of the file, I don't mind.
Collaborator
|
Good idea and PR. Just some minor clean/clear ups :-) |
Codecov Report
@@ Coverage Diff @@
## develop #3016 +/- ##
===========================================
+ Coverage 21.76% 21.82% +0.05%
===========================================
Files 52 52
Lines 11441 11451 +10
===========================================
+ Hits 2490 2499 +9
- Misses 8951 8952 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rejas
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps relative dates accurate when the calendar's fetch frequency is much larger than a minute.
As fetching incurs network traffic and load on servers and most calendars don't update that often, simply refreshing locally is enough.
When using relative for today's events, dates will show as "in X minutes" or "ends in X minutes" for events within an hour and this goes out of date quickly. It's weird to see that the time is, say, 16:30 and an event that you know ends at 16:45 is shown to "ends in 23 minutes" because that's when the last fetch happened.
Please forgive me if there's style issue, I don't have npm set up on my machine to run the formatter.