-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Prevent electron flashing white screen on startup #3001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3001 +/- ##
===========================================
+ Coverage 21.94% 22.09% +0.15%
===========================================
Files 51 51
Lines 11297 11308 +11
===========================================
+ Hits 2479 2499 +20
+ Misses 8818 8809 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I am a little confused, the comment you mention specifies to remove the fullscreen option. |
|
yes, he mentioned to remove That was not necassary in my tests, it was sufficient to add the "transparent" option. Additionally I replaced "autoHideMenuBar" with "frame" (and "hasShadow"). |
0628211 to
c2c14ef
Compare
c2c14ef to
1d143d2
Compare
1d143d2 to
16d77ae
Compare
|
@rejas so if no one else wants to test this we should merge it for getting feedback when it is on |
|
Tested it myself now, lets have a go on develop :-) Sometimes I am wondering how many testers we have there anyway.... |
|
I have build |
see #1919
thanks @dfanica for providing the solution in this comment
tested this on a pi4 with bullseye 32-bit and 64-bit