Skip to content

Switch back to third party fetch lib for all node versions #2961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
khassel merged 4 commits into from
Oct 29, 2022
Merged

Switch back to third party fetch lib for all node versions #2961

khassel merged 4 commits into from
Oct 29, 2022

Conversation

@rejas
Copy link
Collaborator

@rejas rejas commented Oct 29, 2022

As discussed in #2952

@rejas rejas changed the base branch from master to develop October 29, 2022 20:42
@rejas rejas mentioned this pull request Oct 29, 2022
Merged
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2022 •
edited
Loading

Codecov Report

Merging #2961 (99bbe0c) into develop (7058fc5) will increase coverage by 0.34%.
The diff coverage is 74.43%.

@@             Coverage Diff             @@
##           develop    #2961      +/-   ##
===========================================
+ Coverage    22.93%   23.28%   +0.34%     
===========================================
  Files           48       48              
  Lines        10008    10034      +26     
===========================================
+ Hits          2295     2336      +41     
+ Misses        7713     7698      -15
Impacted Files Coverage Δ
js/server.js 78.61% <68.80%> (+2.39%) ⬆️
js/app.js 84.03% <100.00%> (+0.76%) ⬆️
js/fetch.js 100.00% <100.00%> (+10.00%) ⬆️
modules/default/updatenotification/node_helper.js 74.28% <0.00%> (+15.71%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@khassel
Copy link
Collaborator

khassel commented Oct 29, 2022

3 things:

Thanks.

@rejas
Copy link
Collaborator Author

rejas commented Oct 29, 2022

Done

@khassel khassel merged commit 3879949 into MagicMirrorOrg:develop Oct 29, 2022
@rejas rejas deleted the fetch_libs branch October 29, 2022 21:11
@rejas rejas mentioned this pull request Oct 30, 2022
Merged
@khassel khassel mentioned this pull request Aug 16, 2023
Merged
@KristjanESPERANTO KristjanESPERANTO mentioned this pull request Aug 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khassel khassel khassel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rejas @codecov-commenter @khassel