Skip to content

Conversation

@khassel
Copy link
Collaborator

@khassel khassel commented Oct 19, 2022

As already discussed here the first shot of the collaboration rules.

We can discuss this in the comments until ready to merge.

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022

Codecov Report

Merging #2954 (0a37da3) into develop (7bd9443) will decrease coverage by 0.07%.
The diff coverage is 64.00%.

@@             Coverage Diff             @@
##           develop    #2954      +/-   ##
===========================================
- Coverage    65.28%   65.21%   -0.08%     
===========================================
  Files           14       14              
  Lines          726      733       +7     
===========================================
+ Hits           474      478       +4     
- Misses         252      255       +3     
Impacted Files Coverage Δ
js/server.js 67.56% <58.62%> (ø)
js/app.js 69.53% <82.35%> (-0.72%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@rejas rejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@rejas rejas requested a review from sdetweil October 20, 2022 11:53
@khassel khassel marked this pull request as ready for review October 20, 2022 22:46
Copy link
Collaborator

@KristjanESPERANTO KristjanESPERANTO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though I'm not an official reviewer, it looks good to me too 🙂

@rejas
Copy link
Collaborator

rejas commented Oct 31, 2022

Good morning @sdetweil are you fine with these ?

Copy link
Collaborator

@sdetweil sdetweil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, looks good

@rejas
Copy link
Collaborator

rejas commented Oct 31, 2022

by the way, might it make sense to add @MichMich to the discurs channel too?

@rejas rejas merged commit 4fecffc into MagicMirrorOrg:develop Oct 31, 2022
@khassel khassel deleted the collaboration branch October 31, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants