Add error handling to node_helper startup sequence #2945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2945 +/- ##
===========================================
- Coverage 64.06% 63.54% -0.53%
===========================================
Files 9 9
Lines 295 299 +4
===========================================
+ Hits 189 190 +1
- Misses 106 109 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
buxxi
reviewed
Oct 15, 2022
buxxi
reviewed
Oct 19, 2022
khassel
approved these changes
Oct 19, 2022
buxxi
approved these changes
Oct 19, 2022
Collaborator
|
"never merge your own PR" ... |
Collaborator
Author
|
wups :-( |
Collaborator
Author
|
will be more patient with my weather refactor branch, I promise! |
Collaborator
|
tell me if you want to wait for more approvals there or if I should merge ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2944
Also splits the Server js into a constrcutor and an open call to remove one callback parameter :-)