Skip to content

[Bug] Evening compliments are shown during the day #3727

@rejas

Description

@rejas

Environment

SYSTEM: manufacturer: Apple Inc.; model: MacBookPro18,3; virtual: false

OS: platform: darwin; distro: macOS; release: 15.3.1; arch: arm64; kernel: 24.3.0

VERSIONS: electron: 32.3.0; used node: 22.11.0; installed node: 22.11.0; npm: 10.9.0; pm2: 5.4.3

OTHER: timeZone: Europe/Berlin; ELECTRON_ENABLE_GPU: undefined

Which start option are you using?

npm run start

Are you using PM2?

No

Module

compliments

Have you tried disabling other modules?

  • Yes
  • No

Have you searched if someone else has already reported the issue on the forum or in the issues?

  • Yes

What did you do?

Happens when the compliments array of the morning/day times is not set at all instead of being an empty array.

What did you expect to happen?

no compliments being shown

What actually happened?

evening events are shown since the code falls into them as a fallback

Additional comments

No response

Participation

  • I am willing to submit a pull request for this change.

Metadata

Metadata

Assignees

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions