Skip to content

MagicMirror does not respect fullscreen option specificed in config.js #3174

@alejo4373

Description

@alejo4373

Platform:

  • Raspberry Pi 4. Model B
  • Raspberry Pi OS. Debian 11.7
  • Electron 25.2.0
  • Node : v18.17.1

MagicMirror² Version: 2.24.0

Description: Setting electronOptions: { fullscreen: false } in my config files didn't seem to be working. After digging a bit in js/electron.js I found the following snippet

mainWindow.once("ready-to-show", () => {
	mainWindow.setFullScreen(true);
	mainWindow.show();
});

This snippet sets the window to full-screen regardless of what's specified on electronOptions. Once i removed or commented out the mainWindow.setFullScreen(true); statement I noticed that the value from electronOptions began applying

Steps to Reproduce:

  1. Set electronOptions: { fullscreen: false } on your config.js file
  2. Run MagicMirror with npm run start
  3. Notice that the mirror app opens in full-screen despite what we set in config.js
  4. Locate and open to edit js/electron.js
  5. Locate the line with mainWindow.setFullScreen(true) and remove it or commet it out
  6. Toggle the fullscreen setting in electronOptions in your config file and see how it actually has an effect now after restarting the MagicMirror app.

Expected Results: Setting electronOptions: { fullscreen: false } opens the MM app in a window which is not full-screen. The setting is respected and applies

Actual Results: Setting electronOptions: { fullscreen: false } in config.js is not respected and it does not apply, as such the MM app opens in full-screen

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions