fix: prevent alpha keybinds from exiting text input areas#85
Merged
MacroPower merged 1 commit intomainfrom Aug 3, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
==========================================
+ Coverage 54.30% 54.35% +0.05%
==========================================
Files 43 43
Lines 5359 5365 +6
==========================================
+ Hits 2910 2916 +6
Misses 2357 2357
Partials 92 92 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #82
This PR prevents alpha keybinds that are also assigned to navigation actions from exiting text input areas (e.g. hjkl).
Unfortunately input handling is still all over the place in the ui package, and thus this/similar bugs probably will be easy to re-introduce somewhere until I refactor it. I've added an end-to-end test to try to prevent this from happening.