Build and publish Pyodide wheels#161
Merged
bashtage merged 9 commits intoMacPython:mainfrom Sep 12, 2024
Merged
Conversation
This was referenced Aug 29, 2024
Contributor
Author
|
Additionally, I removed the |
4 tasks
Contributor
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a few things across the workflow(s):
CIBW_-prefixed environment variables for building Pyodide wheels. This requires a bump to thecibuildwheelversion, which has been updated to version 2.20.0, the latest available stable version. Support for building and publishing Pyodide wheels was introduced in version2.19.0.cibuildwheelfrom being pip-installed to its action as provided in the GitHub Actions marketplaceNote
I didn't run the test command for the Pyodide wheel step as of now, because of two reasons:
pow_ddsymbol when running the test suite (which I'll return in a while to investigate). If I am requested to enable the testing by the maintainers here, I can bring the alternative Node.js-based test runner file where the symbol visibility bug doesn't post a problem and use it to test the wheel here. Alternatively, the statsmodels submodule in this repository can be updated, and the file will appear. Please let me know if you would like me to do that.pytest-xdistis not usable. Hence, testing the wheels takes much longer (~30 minutes). It will still be faster than the "ubuntu-latest, Python cp3X" jobs, however1.This is a follow-up PR after statsmodels/statsmodels#9270, which describes the rationale for this change. Please let me know if points two and three are better placed in a separate PR. Thank you!
Footnotes
Those jobs run for more than an hour, would it be alright if I parallelise them across the trio of manylinux-x86_64, musllinux-x86_64, and manylinux-aarch64? Doing this will lead to a 43% speedup – if yes, I could do so in a separate PR to keep the diff cleaner. ↩