refactor to acutally use DYNAMIC_LIST#181
Merged
mattip merged 1 commit intoMacPython:maintenance/v0.3.27.44from Aug 11, 2024
Merged
refactor to acutally use DYNAMIC_LIST#181mattip merged 1 commit intoMacPython:maintenance/v0.3.27.44from
mattip merged 1 commit intoMacPython:maintenance/v0.3.27.44from
Conversation
mattip
commented
Aug 11, 2024
| echo done building, now testing | ||
| make BUFFERSIZE=20 DYNAMIC_ARCH=1 \ | ||
| USE_OPENMP=0 NUM_THREADS=64 \ | ||
| BINARY=$bitness $interface_flags $target_flags tests |
Collaborator
Author
There was a problem hiding this comment.
I think this may have been the problem. I did it to break up the build and try to get some log files, since on TravisCI there is a hard limit on the size of the logs. But make test requires make shared, and the command here was without the DYNAMIC_LIST. So make rebuilt all the kernels :(.
Collaborator
Author
|
Comfirmed this time, the manylinux_x86_64 wheels have a 21MB shared object instead of a 35MB one. |
This was referenced Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the version in pyproject.toml and made sure it matches
git describe --tags --abbrev=8in OpenBLAS at theOPENBLAS_COMMITdon't redirect, add QUIET_MAKE to see if travis log file is still too big
move some variables around
Trying this out locally, it seems I should see
-DDYN_PRESCOTT -DDYN_NEHALEM -DDYN_SANDYBRIDGE -DDYN_HASWELL -DDYN_SKYLAKEXin the cc command line in the logs