MAINT: refactor to select sort method later, removing duplicated code paths #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaanasArora
approved these changes
Nov 22, 2025
Owner
MaanasArora
left a comment
There was a problem hiding this comment.
Nice! Yes we have access to the context - looks great, thanks a lot!
f9e6bfb
into
MaanasArora:enh/new-style-string-sorts
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MaanasArora - I wondered again about
NpyAuxDataand realized I was just making things difficult: we have the context in the loop so there is no reason not just to select the relevant internal function there. It allows removing 4 functions!